Issue #1855: ding-libs.dhash: don't use backward jumps - ding-libs

SSSD / ding-libs

#1855 ding-libs.dhash: don't use backward jumps

Closed: Fixed Opened Apr 2, 2013 by okos.

Scope of the function hash_iter_next uses backward jumps and is hard to read, it should be rewritten.
By fixing this, also coverity issue CID 10058 should be fixed.

dhash/dhash.c:static hash_entry_t *hash_iter_next

 726 state_3a:
 727    if (iter->p == NULL) goto state_3b;
 728    entry = &iter->p->entry;
 729    iter->p = iter->p->next;
 730    return entry;
 731 state_3b:
 732    iter->j++;
 733    goto state_2;
 734
 735    /* Should never reach here */
CID 10058 (#1 of 1): Structurally dead code (UNREACHABLE)unreachable: This code cannot be reached: "fprintf(stderr, "ERROR hash...".
 736    fprintf(stderr, "ERROR hash_iter_next reached invalid state\n");
 737    return NULL;
 738}