#1857 ding-libs.ini: dead code
Closed: Fixed Opened by okos.

ini/ini_parse.c:static int handle_kvp

 987    /* Strip spaces around "=" */
 988    /* Since eq > str we can substract 1 */
 989    len = eq - str - 1;
cond_at_least: Condition "len > 0U", taking true branch. Now the value of "len" is at least 1.
cond_at_most: Condition "len > 0U", taking false branch. Now the value of "len" is at most 0.
decr: Decrementing "len". The value of "len" is now at least 0.
cond_const: Condition "len > 0U", taking false branch. Now the value of "len" is equal to 0.
 990    while ((len > 0) && (isspace(*(str + len)))) len--;
 991    /* Adjust length properly */
incr: Incrementing "len". The value of "len" is now at least 2.
incr: Incrementing "len". The value of "len" is now 1.
 992    len++;
at_least: At condition "len", the value of "len" must be at least 1.
dead_error_condition: The condition "!len" cannot be true.
 993    if (!len) {
CID 10048 (#1 of 1): Logically dead code (DEADCODE)dead_error_begin: Execution cannot reach this statement ";".
 994        TRACE_ERROR_STRING("No key", str);
 995        po->last_error = ERR_NOKEY;
 996        *action = PARSE_ERROR;
 997        return EOK;
 998    }

Fields changed

patch: 0 => 1

Fields changed

milestone: NEEDS_TRIAGE => Tools 1.0.1

Fields changed

rhbz: => 0

Fields changed

owner: somebody => okos
status: new => assigned

Fields changed

resolution: => fixed
status: assigned => closed

_comment0: * master: e9a8759bcc696d78ce9d8187e263cfd90c96fdef => 1365609505130931

Metadata Update from @okos:
- Issue assigned to okos
- Issue set to the milestone: Tools 1.0.1

Metadata