SSSD / ding-libs

#2769 Incorrect comment in ini_augment_ut.c
Closed: Fixed Opened by rharwood.

Closed: Fixed
Reopen Issue

Starting at line 217:

    /* Match all that do not start with 'r'                                    
    * and end with '.conf' and then match all                                  
    * ending with '.conf' */
    const char *sections[] = { "config",
                           "monitor",
                               "domains",
                               "services",
                               "provider",
                               NULL };

This is probably a copy-paste error from immediately before it:

    /* Match all that do not start with 'r'                                    
    * and end with '.conf' and then match all                                  
    * ending with '.conf' */
    const char *patterns[] = { "#",
                           "^[^r][a-z]*\\.conf$",
                               "^real\\.conf$",
                               NULL };

Since this is test code, this bug is relatively minor; however, it does make trying to figure out how to call ini_config_augment() more difficult.

Thanks!

Fields changed

cc: => lslebodn@redhat.com
owner: somebody => rharwood

Patched pushed to master as 4b45e0a12ba5cb883891cfa0ab596c00bc9dac6a; this can therefore be closed.

You're right, thanks for the reminder.

btw I don't see us having an appropriate milestone for ding-libs.next, OK if I create 0.6.0 ?

Sounds good to me. Hopefully the patches I posted for #2770 and #2771 can also find their way in that way.

Replying to [comment:4 rharwood]:

Sounds good to me. Hopefully the patches I posted for #2770 and #2771 can also find their way in that way.

Hmm I only see one patch from you on sssd-devel..?

Fields changed

milestone: NEEDS_TRIAGE => ding-libs 0.6.0
resolution: => fixed
status: new => closed

Replying to [comment:5 jhrozek]:

Replying to [comment:4 rharwood]:

Sounds good to me. Hopefully the patches I posted for #2770 and #2771 can also find their way in that way.

Hmm I only see one patch from you on sssd-devel..?

That's my fault... sent to the wrong list. Should be there now.

Fields changed

rhbz: => 0

Metadata Update from @rharwood:
- Issue assigned to rharwood
- Issue set to the milestone: ding-libs 0.6.0
Metadata
None
None
None
High
defect
INI Parser
master
0
None
0
0
0
0
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.