SSSD / ding-libs

#3175 readdir_r deprecation warning
Closed: fixed Opened by mzidek.

Closed: fixed
Reopen Issue

We use readdir_r in the augmentation code. This function is deprecated. We should update the code to use readdir (man 3 readdir) or something else.

ini/ini_augment.c: In function ‘ini_aug_construct_list’: ini/ini_augment.c:418:9: warning: ‘readdir_r’ is deprecated [-Wdeprecated-declarations] error = readdir_r(dir, entry, &entryp); ^~~~~ In file included from ini/ini_augment.c:28:0: /usr/include/dirent.h:183:12: note: declared here extern int readdir_r (DIR *__restrict __dirp,

Can you assess how much work this would be? If not much, lets' do it in the upcoming release. Warnings are not nice.

Metadata Update from @jhrozek:
- Custom field component adjusted to None
- Custom field selected adjusted to None
- Custom field type adjusted to None
- Custom field version adjusted to None

This is not much work. I will send a patch today, I just originally though it may be good for new contributors, but I agree that warnings are not nice.

Metadata Update from @mzidek:
- Issue assigned to mzidek

PR: https://pagure.io/SSSD/ding-libs/pull-request/3176

Master:
- 8ad8417d859997f849cf68a166259c2667214fa9

Metadata Update from @mzidek:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.