Found by clang:
Although the value stored to error on line 850 is used in the enclosing expression, the value is never actually read from error. See http://jhrozek.fedorapeople.org/sssd-clang-llvm/report-LcYMWd.html#EndPath for details.
error
Fields changed
owner: jdennis => dpal
priority: major => minor
milestone: NEEDS_TRIAGE => Tools 1.0
rhbz: => 0
blockedby: => blocking: => coverity: => feature_milestone: => milestone: Tools Backlog => Tools 2.0 patch: => 0
See the following report file https://fedorahosted.org/sssd/attachment/ticket/574/scan-build-2012-09-27-1.tar.bz2 for more details.
design: => design_review: => 0 fedora_test_page: => patch: 0 => 1 selected: =>
Metadata Update from @jhrozek: - Issue assigned to dpal - Issue set to the milestone: Tools 2.0
Perhaps code was changed too much, but I can't find this location. All usages of error variable in dhash.c look sane.
dhash.c
Metadata Update from @atikhonov: - Custom field component adjusted to None (was: DHash) - Custom field design_review reset (from 0) - Custom field patch adjusted to on (was: 1) - Custom field selected adjusted to None - Custom field testsupdated reset (from 0) - Custom field type adjusted to None (was: defect) - Custom field version adjusted to None (was: 1.2.1) - Issue close_status updated to: Invalid - Issue status updated to: Closed (was: Open)