94f331dbc839444a533f95f183fcf1ae0899e150
This should ensure that the appliance image finalization does not get stuck with out-of-order sequence of unmounting to clean up the disk creation working area.
@dcavalca Please test this ASAP to verify this works so I can land this in Fedora before the next compose.
(cc: @pwhalen)
rebased onto a4d23e30daadf83474d700ae46fc3571fb83f02f
rebased onto 9e70c05118dacd608141162840a370f537efa835
rebased onto 94f331dbc839444a533f95f183fcf1ae0899e150
Testing now with the ks from https://koji.fedoraproject.org/koji/taskinfo?taskID=50015418 converted for x86_64 (as https://pagure.io/fedora-btrfs/project/issue/11 is still an issue).
Running sudo /usr/bin/appliance-creator -c koji-image-f34-build-50015418-x86_64.ks -d -v --logfile appliance.log --cache koji-appliance -o app-output --format raw --name Fedora-Xfce-armhfp-Rawhide-20200823.n.2 --version Rawhide --release 20200823.n.2
sudo /usr/bin/appliance-creator -c koji-image-f34-build-50015418-x86_64.ks -d -v --logfile appliance.log --cache koji-appliance -o app-output --format raw --name Fedora-Xfce-armhfp-Rawhide-20200823.n.2 --version Rawhide --release 20200823.n.2
I'm getting a weird package conflict on dnf (possibly because of the arm->x86_64 thing), but the umount logic looks correct:
umount: /var/tmp/imgcreate-envc3fu7/install_root/var/cache/dnf: target is busy. Unable to unmount /var/tmp/imgcreate-envc3fu7/install_root/var/cache/dnf normally, using lazy unmount lazy umount succeeded on /var/tmp/imgcreate-envc3fu7/install_root/var/cache/dnf lazy umount succeeded on /var/tmp/imgcreate-envc3fu7/install_root/var/cache/dnf Unmounting directory /var/tmp/imgcreate-envc3fu7/install_root/boot/efi Unmounting directory /var/tmp/imgcreate-envc3fu7/install_root/boot Unmounting directory /var/tmp/imgcreate-envc3fu7/install_rootbtrfs.007 Unmounting directory /var/tmp/imgcreate-envc3fu7/install_root/home Unmounting directory /var/tmp/imgcreate-envc3fu7/install_root/ Removing compat symlinks Unmapping /dev/loop0 Losetup remove /dev/loop0 [davide@localhost ~]$
Pull-Request has been merged by ngompa
This should ensure that the appliance image finalization does not
get stuck with out-of-order sequence of unmounting to clean up the
disk creation working area.