#18 Port to Python 3
Merged by abompard. Opened by abompard.
abompard/basset py3  into  master

This ports the codebase to Python 3.

It's not easy to understand what happens here, and the change doesn't improve it. :wink:

Unfortunately there's no easy way to say "give me the first value of this OrderedDict". It might help a little if info weren't used for three different things, e.g.:

info = self.core.wikiclient.raw_api(...)
pages = info['query']['pages']
first_page = next(iter(pages.values()))
token = first_page["deletetoken"]

Or, we might finally want to use the "new, untested" way in the else branch. :grinning:

I'm puzzled why this uses the string "None" and not the None object...

Yeah that's what the current FAS returns. Don't ask me...
As for the info thing, I just ported the code to python3 and did not make any refactoring in the hope of limiting possible additional bugs.

I agree this goes beyond porting to Python 3. Looks good to me!

That's weird, the "Merge" button dropdown does not contain a Merge button. Any idea what's going on @pingou ?

@abompard AIUI it means a lack of permissions, the UI could be better. :wink:

Pull-Request has been merged by abompard