PR#190: bind-9.16: another try -

bind-dyndb-ldap

#190 bind-9.16: another try

Closed Sep 14, 2020 by abbra. Opened May 22, 2020 by slev.

slev/bind-dyndb-ldap bind-9.16-support into master

bind-9.16: isc_event_allocate cannot fail gracefully now

Stanislav Levin • May 25, 2020

71f21943a82275c6a67fc028d42e4489aa7814fe

tests: Run all tests

Stanislav Levin • May 25, 2020

f70c0e526d10dbbde0187d52d8c84910a2ecba3c

bind-9.16: Clean up outdated static assertions

Stanislav Levin • May 25, 2020

22675b33d605d478935686bb2d30f3a803bec999

bind-9.16: isc_mem_strdup cannot fail gracefully now

Stanislav Levin • May 25, 2020

050a612b3ef32fef538c29ec6d1fdcba0e9271c2

bind-9.16: isc_mem_allocate cannot fail gracefully now

Stanislav Levin • May 25, 2020

6ec702a6d6be1ad4b2fcca97c6fe5f414333601f

bind-9.16: isc_mem_get cannot fail gracefully now

Stanislav Levin • May 25, 2020

4edd26c96e08b9094ae18d1342cf9eb066c20e24

bind-9.16: Don't re-initialize hash in BIND-only mode

Stanislav Levin • May 25, 2020

240a8182ee7d8dec0b27f9e948b3ef1a77fcbb4c

bind-9.16: Refactor detach dyndb

Stanislav Levin • May 25, 2020

560f7be46bc965d6caf9f536d6ef17d9345ea180

bind-9.16: Refactor dns_fixedname_name

Stanislav Levin • May 25, 2020

c5e4952b238d22f8212bc11d25d7e52456062ef7

bind-9.16: Fix assertions on isc_refcount_init

Stanislav Levin • May 25, 2020

62342212532b46b11a9d229d0bc6b7655158d288

bind-9.16: Clean up isc_ondestroy_init

Stanislav Levin • May 25, 2020

1d21b51b06ed3426879fec5b5c2e7e9d1e5c6a2c

bind-9.16: Correct reference counting

Stanislav Levin • May 25, 2020

3463a075c21a36b5a12f97002e11d0a48ce084b8

bind-9.16: isc_condition_destroy is still neither void nor fatal

Stanislav Levin • May 25, 2020

54f57ae3573cff2ec851fc0738ee73af9948177e

bind-9.16: Follow project's cleanup rule

Stanislav Levin • May 25, 2020

954319ec5bec4cb44fe5a3da93a866c2870c1235

bind-9.11.6: Remove compat defines

Stanislav Levin • May 25, 2020

49629b91506e27a3d7fb36b59c3b462fa529dce0

WIP: test against FreeIPA with bind external pkcs11 engine

Alexander Bokovoy • May 25, 2020

372bd252b5f5e084bd6e2a18b23f4d3c6d9911ee

WIP: Test build against bind 9.16

Alexander Bokovoy • May 25, 2020

11d1def5788c5f05b2280a2cd57edfc2997dac58

bind-9.16: Use dns_name_copynf(...) for RUNTIME_CHECK(dns_name_copy(..., NULL))

Thomas Woerner • May 25, 2020

95b6e721f8ccf0b342645a95c99781ecf62343af

isc-bind 9.16: Temporary define HAVE_TLS and HAVE_THREAD_LOCAL

Thomas Woerner • May 25, 2020

fbfb261abff21da16cadb16471fcca72915b65f9

bind-9.16: dns_dbmethods_t has three more entries

Thomas Woerner • May 25, 2020

17c8305e4fbd130c969ecdaf44eeed71c528cde1

bind-9.16: findzonecut and dns_db_findzonecut has additional parameter

Thomas Woerner • May 25, 2020

fab57f59d75979e31d63824a9b03333dfd5028cd

bind-9.16: dns_zone_load has additional parameter

Thomas Woerner • May 25, 2020

ea604f72f1528a99a6cebecf3d028d990ec2e8f2

bins-9.16: dns_zone_setfile has additional parameters

Thomas Woerner • May 25, 2020

6fbaa9f90208b71b903cf27c48e66e9fe2e7b179

bind-9.16: dns_fwdtable_find has additional parameter

Thomas Woerner • May 25, 2020

953b25e7eee7b7a9bceec2bfce5f642f3a740054

bind-9.16: cfg_print_grammar has additional parameter

Thomas Woerner • May 25, 2020

6e37e870924f60746f1401a13002e873a73e7a7b

bind-9.16: Use dns_byaddr_createptrname instead of dns_byaddr_createptrname2

Thomas Woerner • May 25, 2020

3bcb7d2ec8c108d77d13a9888edfab42e5a47e9a

bind-9.16: Use dns_zone_getserial instead of dns_zone_getserial2

Thomas Woerner • May 25, 2020

abf19124f1d02d834be1889ff16aaa9218cdd1df

bind-9.16: dns_zone_setdbtype is now void

Thomas Woerner • May 25, 2020

0870cfe45482e89cb9977677d9270e8dcf295432

bind-9.16: isc_refcount_t is now atomic_uint_fast32_t only

Thomas Woerner • May 25, 2020

515341d98e70952346e3e9bf49569b787785d88e

bind-9.16: dns_rbtnodechain_init has only one parameter

Thomas Woerner • May 25, 2020

9bc0f02fbb5c4229b6069325d29709ba71a8456d

bind-9.16: dns_view_flushcache has an additional parameter

Thomas Woerner • May 25, 2020

f9104b6ad5e93f7491205f92ebd1e6f317db4262

bind-9.16: Use const for dns_name_t root name

Thomas Woerner • May 25, 2020

d35b642cacd54f982b7079d8abd67e301f4d23d6

bind-9.16: STATIC_ASSERT is now provided by isc/util.h

Thomas Woerner • May 25, 2020

d876325c54b701bfdeb6426fb8b709a065d01a7c

bind-9.16: Handle dns_db_rpz_ deprecations

Thomas Woerner • May 25, 2020

72f910f9807c20720418278bcb76493e1ba1bfee

bind-9.16: Remove isc_ondestroy_init

Thomas Woerner • May 25, 2020

49d93d0564f53b1e123fae7caa50c91ebed2d750

bind-9.16: isc_thread_ functions are void and failures are fatal

Thomas Woerner • May 25, 2020

80445703c4261270be53e3bef32c028151f6a70f

bind-9.16: Use reworked isc_refcount_ functions

Thomas Woerner • May 25, 2020

1c56646c429605e172c04e236b98efbc6992e7e6

bind-9.16: isc_mutex_ fuctions are void and failures are fatal

Thomas Woerner • May 25, 2020

e98aa21d27294f07c14d9c9b2327319871ba9d2c

bind-9.16: Replace removed isc_string_ functions

Thomas Woerner • May 25, 2020

5af566caa5b599437234417474a2219783dc9bd5

bind-9.16: isc_buffer_allocate is now void

Thomas Woerner • May 25, 2020

0d927ba188595c4fc12dd611e6ccb92fefb926b3

bind-9.16: cfg_parse_buffer changes

Thomas Woerner • May 25, 2020

474c2171ca8f9443c80564cbd0e13c89e4522a82

bind-9.16: Lowercase DNS_SSUMATCHTYPE_* -> dns_ssumatchtype_*

Thomas Woerner • May 25, 2020

3b34807f481de612fbf42e1bd8858a2fca0b5c15

Download 190.patch

slev commented May 22, 2020

This PR is based on Tomas PR:
https://pagure.io/bind-dyndb-ldap/pull-request/187

The changes list was composed as the list of all the changes touched the corresponding dyndb tests in upstream, something like this:

git log -p upstream/v9_11_8_release..upstream/v9_16_3-release -- bin/tests/system/dyndb/

There is still a bunch of problems I want to test/fix, but most of the changes were done (hope).

41 new commits added

tests: Run all tests
bind-9.16: Clean up outdated static assertions
bind-9.16: isc_mem_strdup cannot fail gracefully now
bind-9.16: isc_mem_allocate cannot fail gracefully now
bind-9.16: isc_mem_get cannot fail gracefully now
bind-9.16: Don't re-initialize hash in BIND-only mode
bind-9.16: Refactor detach dyndb
bind-9.16: Refactor dns_fixedname_name
bind-9.16: Fix assertions on isc_refcount_init
bind-9.16: Clean up isc_ondestroy_init
bind-9.16: Correct reference counting
bind-9.16: isc_condition_destroy is still neither void nor fatal
bind-9.16: Follow project's cleanup rule
bind-9.16: Remove compat defines
WIP: test against FreeIPA with bind external pkcs11 engine
WIP: Test build against bind 9.16
bind-9.16: Use dns_name_copynf(...) for RUNTIME_CHECK(dns_name_copy(..., NULL))
isc-bind 9.16: Temporary define HAVE_TLS and HAVE_THREAD_LOCAL
bind-9.16: dns_dbmethods_t has three more entries
bind-9.16: findzonecut and dns_db_findzonecut has additional parameter
bind-9.16: dns_zone_load has additional parameter
bins-9.16: dns_zone_setfile has additional parameters
bind-9.16: dns_fwdtable_find has additional parameter
bind-9.16: cfg_print_grammar has additional parameter
bind-9.16: Use dns_byaddr_createptrname instead of dns_byaddr_createptrname2
bind-9.16: Use dns_zone_getserial instead of dns_zone_getserial2
bind-9.16: dns_zone_setdbtype is now void
bind-9.16: isc_refcount_t is now atomic_uint_fast32_t only
bind-9.16: dns_rbtnodechain_init has only one parameter
bind-9.16: dns_view_flushcache has an additional parameter
bind-9.16: Use const for dns_name_t root name
bind-9.16: STATIC_ASSERT is now provided by isc/util.h
bind-9.16: Handle dns_db_rpz_ deprecations
bind-9.16: Remove isc_ondestroy_init
bind-9.16: isc_thread_ functions are void and failures are fatal
bind-9.16: Use reworked isc_refcount_ functions
bind-9.16: isc_mutex_ fuctions are void and failures are fatal
bind-9.16: Replace removed isc_string_ functions
bind-9.16: isc_buffer_allocate is now void
bind-9.16: cfg_parse_buffer changes
bind-9.16: Lowercase DNS_SSUMATCHTYPE_* -> dns_ssumatchtype_*

May 22, 2020

42 new commits added

bind-9.16: isc_event_allocate cannot fail gracefully now
tests: Run all tests
bind-9.16: Clean up outdated static assertions
bind-9.16: isc_mem_strdup cannot fail gracefully now
bind-9.16: isc_mem_allocate cannot fail gracefully now
bind-9.16: isc_mem_get cannot fail gracefully now
bind-9.16: Don't re-initialize hash in BIND-only mode
bind-9.16: Refactor detach dyndb
bind-9.16: Refactor dns_fixedname_name
bind-9.16: Fix assertions on isc_refcount_init
bind-9.16: Clean up isc_ondestroy_init
bind-9.16: Correct reference counting
bind-9.16: isc_condition_destroy is still neither void nor fatal
bind-9.16: Follow project's cleanup rule
bind-9.11.6: Remove compat defines
WIP: test against FreeIPA with bind external pkcs11 engine
WIP: Test build against bind 9.16
bind-9.16: Use dns_name_copynf(...) for RUNTIME_CHECK(dns_name_copy(..., NULL))
isc-bind 9.16: Temporary define HAVE_TLS and HAVE_THREAD_LOCAL
bind-9.16: dns_dbmethods_t has three more entries
bind-9.16: findzonecut and dns_db_findzonecut has additional parameter
bind-9.16: dns_zone_load has additional parameter
bins-9.16: dns_zone_setfile has additional parameters
bind-9.16: dns_fwdtable_find has additional parameter
bind-9.16: cfg_print_grammar has additional parameter
bind-9.16: Use dns_byaddr_createptrname instead of dns_byaddr_createptrname2
bind-9.16: Use dns_zone_getserial instead of dns_zone_getserial2
bind-9.16: dns_zone_setdbtype is now void
bind-9.16: isc_refcount_t is now atomic_uint_fast32_t only
bind-9.16: dns_rbtnodechain_init has only one parameter
bind-9.16: dns_view_flushcache has an additional parameter
bind-9.16: Use const for dns_name_t root name
bind-9.16: STATIC_ASSERT is now provided by isc/util.h
bind-9.16: Handle dns_db_rpz_ deprecations
bind-9.16: Remove isc_ondestroy_init
bind-9.16: isc_thread_ functions are void and failures are fatal
bind-9.16: Use reworked isc_refcount_ functions
bind-9.16: isc_mutex_ fuctions are void and failures are fatal
bind-9.16: Replace removed isc_string_ functions
bind-9.16: isc_buffer_allocate is now void
bind-9.16: cfg_parse_buffer changes
bind-9.16: Lowercase DNS_SSUMATCHTYPE_* -> dns_ssumatchtype_*

May 22, 2020

1 new commit added

bind: Temp workaround for rndc-confgen

May 22, 2020

slev commented May 22, 2020

With temp commit all tests passed:
https://dev.azure.com/slev0400/slev/_build/results?buildId=1554&view=results

abbra commented May 23, 2020

Thank you, @slev, much appreciated!

Zones seem to work:

May 22 15:08:44 master1.ipa.test named[8266]: zone 0.18.172.in-addr.arpa/IN: loaded serial 1590160124
May 22 15:08:44 master1.ipa.test named[8266]: zone example.test/IN (signed): loaded serial 1590160124
May 22 15:08:44 master1.ipa.test named[8266]: zone example.test/IN (unsigned): loaded serial 1590160124
May 22 15:08:44 master1.ipa.test named[8266]: zone example.test/IN (signed): receive_secure_serial: unchanged
May 22 15:08:44 master1.ipa.test named[8266]: zone example.test/IN (signed): loaded serial 1590160124
May 22 15:08:44 master1.ipa.test named[8266]: zone example.test/IN (signed): reconfiguring NSEC3PARAM to '0 0 0 00'
May 22 15:08:44 master1.ipa.test named[8266]: zone ipa.test/IN: loaded serial 1590160124
May 22 15:08:44 master1.ipa.test named[8266]: 3 master zones from LDAP instance 'ipa' loaded (3 zones defined, 0 inactive, 0 failed to load)
May 22 15:08:44 master1.ipa.test named[8266]: zone example.test/IN (signed): reconfiguring zone keys
May 22 15:08:44 master1.ipa.test named[8266]: zone example.test/IN (signed): next key event: 22-May-2020 16:08:44.122

NSEC3PARAM with all-zeros is just a default value when nsec3param record is not set in the zone.

rebased onto 3b34807f481de612fbf42e1bd8858a2fca0b5c15

May 25, 2020

slev commented May 25, 2020

Rebased on master.
Removed rndc-confgen workaround (fixed in bind-9.16).

abbra commented Jun 3, 2020

@rjeffman please review.

rjeffman commented Jun 17, 2020

I want to do a few more tests, but this looks good to me.

tjaalton commented Aug 6, 2020

this needs a rebase on current master/11.3

tjaalton commented Aug 6, 2020

well, "needs" for the version number change, that's all

tjaalton commented Aug 14, 2020

fails to build on 32bit:

...
../../src/syncrepl.c: In function ‘sync_task_add’:
../../src/syncrepl.c:460:15: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘unsigned int’ [-Werror=format=]
  460 |  log_debug(2, "adding task %p to syncrepl list; %lu tasks in list",
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

pemensik commented Aug 17, 2020

I have prepared modification to allow building also from BIND 9.11 sources. I did not test it works, it just compiles.

https://pagure.io/fork/pemensik/bind-dyndb-ldap/tree/bind-9.16-support

abbra commented Aug 17, 2020

@pemensik thanks!
Could you please remove the second hunk in https://pagure.io/fork/pemensik/bind-dyndb-ldap/c/b310d9a8dc7aa39afbd2a578c56c3cde3d141306?branch=bind-9.16-support ?
It is definitely not needed, please reduce the diff.

pemensik commented Aug 18, 2020

Okay, I removed unnecessary format change, but added small cleanup removing a variable.

pemensik commented Aug 24, 2020

I have made new build of BIND 9.16.6. It changed db API, new function was added.
Requires modification to compile, provided it in my branch.

abbra commented Sep 14, 2020

I merged a variant of this PR to master.

Pull-Request has been closed by abbra

Sep 14, 2020