PR#19: Remove openshift.withCluster() calls from Builder and Deployer -

c3i-library

#19 Remove openshift.withCluster() calls from Builder and Deployer

Closed Oct 17, 2019 by mikeb. Opened Jun 19, 2019 by rayson.

rayson/c3i-library remove-with-cluster into master

Remove openshift.withCluster() calls from Builder and Deployer

Yuxiang Zhu • Jun 19, 2019

70c16f56f7c574810dfe60a7192d7b9a94e666d2

rayson commented Jun 19, 2019

This will allow users to customize the OpenShift cluster and project
that they want to interact with.

Users are expected to call c3i.foo() functions within a openshift.withCluster() closure. We need to ensure our Jenkinsfile are doing this way before merging this.

lholecek commented Jun 20, 2019

Since this change is backwards-incompatible: Is it possible to use git tags or branches so that future changes won't break existing Jenkins jobs?

gnaponie commented Jun 21, 2019

Users are expected to call c3i.foo() functions within a openshift.withCluster() closure. We need to ensure our Jenkinsfile are doing this way before merging this.

+1, after we are sure this is addressed.

mikeb commented Oct 9, 2019

This change should be obsoleted by #25.

mikeb commented Oct 17, 2019

Closing this PR, since it is now obsolete.

Pull-Request has been closed by mikeb

Oct 17, 2019