Note that these changes are backward-incompatible, but I have changes queued up for the MBS-Koji integration tests to convert to the new API. WaiverDB should be unaffected because it only used c3i.wait(name), which is unchanged.

@rayson @mkovarik @gnaponie @lholecek Please take a look.

"sans"? "without" in French? :)

How about subjectAltName instead?

"sans"? "without" in French? :)
How about subjectAltName instead?

Updated. :)

I may not have enough time to finish review before next Mon. Go ahead if this is urgent :)

@rayson It's not urgent, more of an enabler for using c3iaas from the MBS-Koji integration tests, and hopefully making the library more useful for other projects, like WaiverDB and the Factory2 integration tests. I'm still cleaning up the MBS-Koji changes, and will post a PR for that in the next couple days. I'd appreciate your feedback on these changes since they're so extensive. In particular, let me know if you have any suggestions on the API design, since I'm not a Groovy expert. Thanks for your time! :)

Better to rename variable to ageMinutes or ageInMinutes instead.

Are these variables safe? It looks like it could lead to shell injection (passwd="123; rm -rf --no-preserve-root /").

Are these variables safe? It looks like it could lead to shell injection (passwd="123; rm -rf --no-preserve-root /").

I'm not sure how to avoid this using the sh step, suggestions? Single-quotes around the variables, maybe?

I'm not sure how to avoid this using the sh step, suggestions? Single-quotes around the variables, maybe?

It's probably not very important. I think passing values through using environment variables should be safe.

Are these variables safe? It looks like it could lead to shell injection (passwd="123; rm -rf --no-preserve-root /").

I'm not sure how to avoid this using the sh step, suggestions? Single-quotes around the variables, maybe?

It is possible to use the withEnv step to inject environment variables to the sh step and reference them in your shell script. For example, on https://pagure.io/waiverdb/blob/master/f/openshift/pipelines/templates/waiverdb-build.Jenkinsfile#_390:

withEnv(["DEST_IMAGE_REF=${dest}"]) {
                  /* Pushes to the internal registry can sometimes randomly fail
                  * with "unknown blob" due to a known issue with the registry
                  * storage configuration. So we retry up to 5 times. */
                  retry(5) {
                    sh 'skopeo copy dir:_build/waiverdb_container "$DEST_IMAGE_REF"'
                  }
                }

Refactored the ca variable to use withEnv when calling sh.

I went through this PR and really love it. Especially those wait functions should be very helpful to reduce duplicates. LGTM!

${servername} was replaced by ${subjectAltNames}, creation of CA is failing since subjectAltNames is not replaced.

Thanks for the feedback!