PR#154: configure: Fix detection of supported NSS db type -

certmonger

#154 configure: Fix detection of supported NSS db type

Merged Jun 9, 2020 by rcritten. Opened Jun 9, 2020 by slev.

slev/certmonger detect_nss_db into master

configure: Fix detection of supported NSS db type

Stanislav Levin • Jun 9, 2020

41a7946bf9e207b63ac3a49eba42fe7e573ee917

slev commented Jun 9, 2020

For now configure always reports about the lack of support for
any NSS db:
checking if NSS supports "sql:" databases... no
checking if NSS supports "dbm:" databases... no

Actually, there is the linking issue, but AC_TRY_RUN is not
designed to detect this.

The recipe is the obeying the proper linking order:
$CC -o conftest$ac_exeext $CFLAGS $CPPFLAGS $LDFLAGS conftest.$ac_ext $LIBS

Fixes: https://pagure.io/certmonger/issue/153

slev commented Jun 9, 2020

This triggers the tests placed under HAVE_DBM_NSSDB and HAVE_SQL_NSSDB.

Edited Jun 9, 2020 by slev

rcritten commented Jun 9, 2020

Curious. This should have never worked. What compiler are you using? Maybe it has stricter enforcement of link order.

slev commented Jun 9, 2020

Right now it is:

gcc --version
x86_64-alt-linux-gcc (GCC) 9.3.1 20200518 (ALT Sisyphus 9.3.1-alt1)

slev commented Jun 9, 2020

I haven't noticed this until yesterday.
I've checked the build log for 0.79.6 (the end of 2018, oldest I have), there was the same problem.

rcritten commented Jun 9, 2020

So pretty much the same version I have. odd, maybe some ld diff. Either way this is obviously correct but I'm going to do some local testing to be sure that at least Fedora is ok with it. Thanks for the patch.

rcritten commented Jun 9, 2020

Checks out ok, merging.

Metadata Update from @rcritten:
- Request assigned

Jun 9, 2020

Pull-Request has been merged by rcritten

Jun 9, 2020