PR#247: Respect LDFLAGS settings defined by user -

certmonger

#247 Respect LDFLAGS settings defined by user

Merged Oct 19, 2022 by rcritten. Opened Oct 17, 2022 by winterheart.

winterheart/certmonger respect-ldflags into master

Respect LDFLAGS settings defined by user

Azamat H. Hackimov • Oct 17, 2022

a303c31d559f02336992be6c463e3d789d502bc9

winterheart commented Oct 17, 2022

Don't wipe LDFLAGS defined by user by setting LDFLAGS env variable.
If variable is empty, it will be correctly updated by += assignemnt.

Metadata Update from @rcritten:
- Request assigned

Oct 17, 2022

rcritten commented Oct 17, 2022

Thanks for the PR, this looks fine. I'm curious, what LDFLAGS are you setting?

winterheart commented Oct 18, 2022

I'm working on adding cermonger to Gentoo package tree, so LDFLAGS checking is part of QA maintenance. Without provided patch portage complains about not respecting LDFLAGS. We use LDFLAGS="${LDFLAGS} -Wl,--defsym=__gentoo_check_ldflags__=0", which does nothing on actual linking but allows to detect such QA warnings.

Edited Oct 18, 2022 by winterheart

rcritten commented Oct 19, 2022

Ah cool. LGTM, ack.

Pull-Request has been merged by rcritten

Oct 19, 2022