certmonger

#295 express payload type via an enum (based on #287)
Closed by rcritten. Opened by ftweedal.
ftweedal/certmonger pr-287-plus-enum  into  master

The proposed enum for payload type (XML or JSON). Suggest to merge #287 first,
then I can update/rebase this PR if needed and review it separately.

I still need to test this but in general it looks good.

I have my paint bucket out. Might I suggest RPC_PROTOCOL instead of PAYLOAD_FORMAT?

8 new commits added

  • express payload type via an enum
  • Pass all=True to certprofile-find to retrieve all profiles
  • Suppress unused arguments to the LDAP SASL interactive callback
  • Fix directive argument is NULL errors (-Wformat-overflow)
  • Fix format-overflow warning when converting time
  • Drop unused cm_submit_d parameters
  • Add tests for the expanded dogtag requests through IPA API
  • Use the IPA API by default for dogtag requests

bikeshed colour change approved. PR updated.

Merged via https://pagure.io/certmonger/pull-request/296

Pull-Request has been closed by rcritten
Metadata
None
No Tags
Changes Summary 49
+25 -11
file changed
src/Makefile.am
+901 -466
file changed
src/dogtag.c
+5 -272
file changed
src/ipa.c
+2 -2
file changed
src/scep.c
+3 -3
file changed
src/store-gen.c
+1 -1
file changed
src/store.h
+428 -38
file changed
src/submit-d.c
+32 -20
file changed
src/submit-d.h
+329
file added
src/util-ipa.c
+28
file added
src/util-ipa.h
+14
file added
tests/019-dparse/bad.checkRequest.nosuch.json
+0 -0
file renamed
tests/019-dparse/bad.checkRequest.nosuch
tests/019-dparse/bad.checkRequest.nosuch.xml
+0 -0
file renamed
tests/019-dparse/bad.displayCertFromRequest.incomplete
tests/019-dparse/bad.displayCertFromRequest.incomplete.xml
+14
file added
tests/019-dparse/bad.displayCertFromRequest.no-such-request.json
+0 -0
file renamed
tests/019-dparse/bad.displayCertFromRequest.no-such-request
tests/019-dparse/bad.displayCertFromRequest.no-such-request.xml
+0 -0
file renamed
tests/019-dparse/bad.displayCertFromRequest.rejected
tests/019-dparse/bad.displayCertFromRequest.rejected.xml
+0 -0
file renamed
tests/019-dparse/bad.profileProcess.bad-property
tests/019-dparse/bad.profileProcess.bad-property.xml
+0 -0
file renamed
tests/019-dparse/bad.profileProcess.no-agent-cert
tests/019-dparse/bad.profileProcess.no-agent-cert.xml
+0 -0
file renamed
tests/019-dparse/bad.profileProcess.no-ca-cert
tests/019-dparse/bad.profileProcess.no-ca-cert.xml
+0 -0
file renamed
tests/019-dparse/bad.profileProcess.no-property
tests/019-dparse/bad.profileProcess.no-property.xml
+0 -0
file renamed
tests/019-dparse/bad.profileProcess.not-pending
tests/019-dparse/bad.profileProcess.not-pending.xml
+0 -0
file renamed
tests/019-dparse/bad.profileReview.no-such-request
tests/019-dparse/bad.profileReview.no-such-request.xml
+0 -0
file renamed
tests/019-dparse/bad.profileReview.unauthorized-cert
tests/019-dparse/bad.profileReview.unauthorized-cert.xml
+0 -0
file renamed
tests/019-dparse/bad.profileReview.wrong-nssdb
tests/019-dparse/bad.profileReview.wrong-nssdb.xml
+14
file added
tests/019-dparse/bad.profileSubmit.csr.empty.json
+0 -0
file renamed
tests/019-dparse/bad.profileSubmit.csr.empty
tests/019-dparse/bad.profileSubmit.csr.empty.xml
+14
file added
tests/019-dparse/bad.profileSubmit.csr.invalid.json
+0 -0
file renamed
tests/019-dparse/bad.profileSubmit.csr.subject-mismatch
tests/019-dparse/bad.profileSubmit.csr.subject-mismatch.xml
+0 -0
file renamed
tests/019-dparse/bad.profileSubmit.serial.empty
tests/019-dparse/bad.profileSubmit.serial.empty.xml
+0 -0
file renamed
tests/019-dparse/bad.profileSubmit.serial.invalid
tests/019-dparse/bad.profileSubmit.serial.invalid.xml
+0 -0
file renamed
tests/019-dparse/bad.profileSubmit.serial.out-of-range
tests/019-dparse/bad.profileSubmit.serial.out-of-range.xml
+232 -51
file changed
tests/019-dparse/expected.out
+15
file added
tests/019-dparse/good.checkRequest.complete.json
+0 -0
file renamed
tests/019-dparse/good.checkRequest.complete
tests/019-dparse/good.checkRequest.complete.xml
+15
file added
tests/019-dparse/good.checkRequest.pending.json
+0 -0
file renamed
tests/019-dparse/good.checkRequest.pending
tests/019-dparse/good.checkRequest.pending.xml
+0 -0
file renamed
tests/019-dparse/good.displayCertFromRequest-extra-line
tests/019-dparse/good.displayCertFromRequest-extra-line.xml
+26
file added
tests/019-dparse/good.displayCertFromRequest.json
+0 -0
file renamed
tests/019-dparse/good.displayCertFromRequest
tests/019-dparse/good.displayCertFromRequest.xml
+1140
file added
tests/019-dparse/good.profileList.json
+0 -0
file renamed
tests/019-dparse/good.profileList
tests/019-dparse/good.profileList.xml
+0 -0
file renamed
tests/019-dparse/good.profileReview
tests/019-dparse/good.profileReview.xml
+33
file added
tests/019-dparse/good.profileSubmit.issued.json
+0 -0
file renamed
tests/019-dparse/good.profileSubmit.issued
tests/019-dparse/good.profileSubmit.issued.xml
+0 -0
file renamed
tests/019-dparse/good.profileSubmit.serial.in-range
tests/019-dparse/good.profileSubmit.serial.in-range.xml
+38 -7
file changed
tests/019-dparse/run.sh
+34 -25
file changed
tests/Makefile.am
+1 -1
file changed
tests/tools/Makefile.am
+91 -36
file changed
tests/tools/dparse.c
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.