Are they currently tagged as "CloudSIG" or are they entirely missing the tag? https://pagure.io/cloud-image-uploader/pull-request/41 should fix it if it's the former, otherwise, I'll need to figure out why the tag isn't getting applied

So, I see recent ones are tagged CloudSIG... but old ones not?

ie, ap-east-1 ami-0298cb826f2673f11 doesn't have it and it was created 2024-10-04T18:23:04.000Z

so, perhaps all the early ones need to be tagged retoractively and this was added after they were created?

Yeah, so initially I wasn't aware of the tagging scheme for AWS and so early images don't have the tag. All new ones should be tagged (but with "CloudSIG" and not "infra").

I didn't try to figure out how to go back and retroactively tag the images that were added without the tag, but the fix got committed October 11th so everything after that should be tagged.

ok, makes sense.

I guess we could do a one off thing to tag all the old ones (helpfully listed in the mailing list report)?

Or are they going to be GC'ed at some point and we should just not worry?

I think Miroslav will eventually delete them since they're untagged. It's a bit of a hassle to tag them manually since they're also supposed to be tagged with a EOL date for automatic garbage collection. You could give them all 365 days or something, but it's probably just easier to let them be deleted for being untagged.

I just deployed the commit that changes the tag from "CloudSIG" to "infra", so all things tagged from now on will include that, and everything between October ~11th and today will have the "CloudSIG" tag.

ok. So, I guess we could just close this and let them all slowly get GCed then?

works for me