cloud-image-uploader

#11 Drop ReleaseInfo class now fedfind provides what we need
Merged by jcline. Opened by adamwill.
adamwill/cloud-image-uploader no-relinfo  into  main

fedfind 5.2.0 provides the relnum and eol properties which we
were previously using this to contain. So, let's just use them
from there, and simplify the code here.

This obviously means we require fedfind 5.2.0, but none of the
other requirements are versioned so I didn't version this one.

Signed-off-by: Adam Williamson awilliam@redhat.com

rebased onto e6d4ee406c39cf6f2ddf852552a8351939d951aa

You can add azure_fm_conf to the fixture list for this test and it will patch the fedora-messaging config with the same dictionary you've got here.

This will need a rebase and its cassette regenerated, but otherwise it looks good to me.

You can add azure_fm_conf to the fixture list for this test and it will patch the fedora-messaging config with the same dictionary you've got here.

test_gallery_name and test_old_unsupported_azure_compose do the same, I was just following those. I guess I can add a preliminary commit that changes both of those too?

You can add azure_fm_conf to the fixture list for this test and it will patch the fedora-messaging config with the same dictionary you've got here.

test_gallery_name and test_old_unsupported_azure_compose do the same, I was just following those. I guess I can add a preliminary commit that changes both of those too?

Yeah, I think I must have missed those when adding the fixture. Thanks!

rebased onto bd6b7ab0b27d4167e9051a5069da47b6311b79bb

OK, rebased with a preliminary commit that fixes up the handling of consumer_config in general, conflicts resolved, and the cassette regenerated.

Locally the tests still fail because the cassette doesn't have a request to PDC. Not sure why, but a fresh record works fine. Unfortunately I can't push to your branch or I'd just do that and merge this.

2 new commits added

  • Drop ReleaseInfo class now fedfind provides what we need
  • Consistently use the azure_fm_conf fixture

Hah, I think I didn't record it with the updated fedfind (didn't update my package install and didn't run pytest with PYTHONPATH set to my local fedfind copy). Pushed again, it should be right now.

Pull-Request has been merged by jcline
Metadata
None
No Tags
Changes Summary 3
+29 -65
file changed
fedora_cloud_image_uploader/handler.py
+1417
file added
tests/fixtures/cassettes/test_eol_synthesis.yaml
+34 -65
file changed
tests/test_handler.py
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.