PR#36: new script: compose-create-next-dir -

compose-utils

#36 new script: compose-create-next-dir

Merged Feb 14, 2017 by lsedlar. Opened Feb 14, 2017 by qwan.

qwan/compose-utils create-next-dir into master

Qixiang Wan • Feb 14, 2017

53df522f2b8a989d756cc71ccc430935312b43ff

qwan commented Feb 14, 2017

A new script compose-create-next-dir is added, it can create empty
directory for next compose, compose ID is determined by parsing the
config file.

get_compose_dir is copied from pungi with minor changes. Pungi is not
intended to be used as a library, so not import pungi to use the
function.

Signed-off-by: Qixiang Wan qwan@redhat.com

lsedlar commented Feb 14, 2017

Is this condition always going to evaluate to True? (I understand the code is coming from Pungi which has this useless condition as well, but why not improve it.)

rebased

Feb 14, 2017

qwan commented Feb 14, 2017

good catch, updated, I'll update pungi as well.

lsedlar commented Feb 14, 2017

Looks good to me, merging.

Pull-Request has been merged by lsedlar

Feb 14, 2017

ausil commented Feb 14, 2017

What's the purpose of this? You really can not know the next compose id until you run it.

lsedlar commented Feb 14, 2017

@ausil The ultimate goal is better automation of composing. The point is to start the compose in that particular directory and have the path (and compose id) available without parsing the output (essentially moving the starting of compose to another tool). This is not yet going the whole way yet.