#81 compose-has-build: check any epoch for an NVR
Merged by lsedlar. Opened by ktdreyer.
ktdreyer/compose-utils has-build-ignore-epoch  into  master

Prior to this change, if a user specified a build NVR without an epoch
to compose-has-build, then compose-has-build would assume an epoch value
of "0". If the compose contained the build with a non-zero epoch, then
compose-has-build would fail to find it.

The problem is that Koji's BuildStateChange messages do not contain the
epoch at all. Koji announces builds with plain NVRs, so we don't know
what epoch value use. This means we cannot use compose-has-build with
Koji's build announcement messages if the build has a non-zero epoch.

Make compose-has-build match any epoch value in the compose.

This looks a little surprising. Can you switch the call above to parse_nvra? Then the release will be parsed correctly and there will be no need to add the '.src'.

With this patch, the epoch is ignored even if there is one specified in the input (if you ask about 1:1.0, it will find 0:1.0). I'm fine with that change, but the manual page (man/compose-has-build.1) should be updated to match this behaviour.

I opened #82 that addresses my comment above.

Great! I will close this one and we can continue with #82

Pull-Request has been closed by ktdreyer

Commit 96923fe1 fixes this pull-request

Pull-Request has been merged by lsedlar