fedora-ci / AtomicCi

#7 Add tests to the gc package using a -tests subpackage
Closed by pingou. Opened by pingou.
gc_tests2  into  master

This is a different approach than #7 which involves changes in the spec file (so is more intrusive) but has also some benfits, such as ensure the test program is compiled with the same gcc version of the rest of gc.

~~It also means the gc spec file can no longer be built from scratch in one go since the -tests subpackage build requires gc-devel (which is created in the same spec), ie: it would needs bootstrapping now.~~
With help from @stefw the spec file has been adjusted to drop this issue

I like the approach of gc-tests in general.

It should be trivial to just pass a -I%{_builddir}/path/toheaders to gcc to find the headers that were just built/used during the main %build step. No bootstrapping should be necessary.

1 new commit added

  • Drop the BR on gc-devel

Adjusted :)

Lets be consistent and just install gc-tests here and use it directly

Sure

2 new commits added

  • Refactor the ansible playbook to be more straight forward
  • Fixup how is made available the gc-tests package

We just need gc and gc-tests in this list.

I don't think you need/use subjects. The inventory script can use it. No need to declare here.

yes and gcc adn gc-devel can be dropped now

:thumbsup:

No tags needed here.

No tags needed here.

will remove

No tags needed here

2 new commits added

  • Use a block construct and sync the artifacts at the end
  • Drop un-needed tags and adjust package to install

I haven't run this but it LGTM.

Once standard-test-scripts is included in standard-test-roles, we could remove a bunch of the boilerplate here. But this is good for a first round.

extra comments

same as on https://pagure.io/fedora-ci/AtomicCi/pull-request/6#

Let's close this PR since it got opened upstream

Pull-Request has been closed by pingou
Metadata
None
No Tags
Changes Summary 3
+384
file added
gc/gc.spec
+57
file added
gc/tests.yml
+23
file added
gc/tst-gc.c
Powered by Pagure 1.0.0
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.