LGTM :thumbsup:

It looks like this test will start failing if we remove skipping of IoT from the configuration file. It feels like we should inject that value here like {"consumer_config": {"composes_to_skip": ["IoT"]}}, instead of relying on that setting in the config file

took FAILED is awkward. reword?

how about we say Compose phase {p} time: instead of "took"

why don't we move this back to the top and just add another variable.. so at the top we have:

linedate = lines[x-1][:19]
line = lines[x-1][20:]   # trim date off log lines
nextline = lines[x][20:] # trim date off log lines

and then you can use dt.datetime.fromisoformat(linedate) in the two calls above

@cverna - a few comments from me above ^^

nice work - and thanks for doing this.

Changed :thumbsup:

Changed :thumbsup:

Yes, I used at during development to make sure that the config file was valid and that I could access the value in it. But I agree it would be better to just mock it so I have changed it :-).

:thumbsup: updated

@dustymabe I have addressed your comments. Thanks for the review :smile:

@cverna - this LGTM

Since we are moving to Fedora 31 we need to "redeploy" the app to get a new imagestream.

What do you think about trying your hand at deploying this app to stage and then to prod openshift?
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org/message/DR53T4YLQ57DHWWY64EU3BOALIXALBFE/

can you merge this?

@cverna - this LGTM
Since we are moving to Fedora 31 we need to "redeploy" the app to get a new imagestream.
What do you think about trying your hand at deploying this app to stage and then to prod openshift?
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org/message/DR53T4YLQ57DHWWY64EU3BOALIXALBFE/

Works for me :thumbsup:

can you merge this?

Nope I don't have the correct permissions.

gave you write access to the repo too!